Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Do not pass scp-style URLs to the WhatWG url.URL #62

Closed
wants to merge 2 commits into from
Closed

fix: Do not pass scp-style URLs to the WhatWG url.URL #62

wants to merge 2 commits into from

Conversation

isaacs
Copy link
Contributor

@isaacs isaacs commented Feb 26, 2020 •
edited
Loading

Fix #60 (for the legacy branch)
Fix #61

@isaacs
fix: Do not attempt to use url.URL when unavailable
bb123d2 
Fix #61

This should not be ported to the latest branch, as Node.js v6 support
was dropped there anyway.
@billneff79
Copy link

@isaacs - I put forward an alternative fix in PR #64 that gets rid of url.URL all together. I don't care which gets merged, as long as one of the fixes does

This was referenced Feb 26, 2020
Closed
Closed
isaacs added a commit that referenced this pull request Feb 26, 2020
@isaacs
fix: Do not attempt to use url.URL when unavailable
2d0bb66 
Fix #61

This should not be ported to the latest branch, as Node.js v6 support
was dropped there anyway.

PR-URL: #62
Credit: @isaacs
Close: #62
Reviewed-by: @isaacs
@darcyclarke
Copy link
Contributor

Closing as both PRs w/ this work have landed against latest & legacy

@wraithgar wraithgar deleted the isaacs/fix-60-legacy branch September 21, 2021 14:23
@JACKEYBANKZ JACKEYBANKZ mentioned this pull request Oct 24, 2021
Open
@sync-by-unito sync-by-unito bot mentioned this pull request Mar 25, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darcyclarke darcyclarke Awaiting requested review from darcyclarke

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@isaacs @billneff79 @darcyclarke